User "Catrope" posted a comment on MediaWiki.r93565. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93565#c20586 Commit summary:
Add back one insertion to the templatelinks table that was removed in the IWTransclusion merge and ended up breaking ArticleTablesTest::testbug14404 Comment: In fact, it's better to put the <code>if ( isset( $insertions['foo'] ) )</code> blocks outside of the <code>if ( count( $insertions ) )</code> block so the count is only checked when it's actually needed, and isn't checked twice. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
