User "Krinkle" posted a comment on MediaWiki.r93782. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93782#c20602 Commit summary:
break dependency on utility functions isEmpty & isDefined Comment: Although the function isn't entirely the same, there is a <code>isEmpty</code> in core as well. See [[RL/DM#jQuery_Extension|$.isEmpty]] ([http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/jquery/jquery.mwExtension.js?revision=94227&view=markup#l20 source]). Since you're only checking for null/undefined and empty string this is prolly better than $.isEmpty though. Nice work on getting this in core, gonna make a lot of things easier. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
