User "Catrope" changed the status of MediaWiki.r92923. Old Status: new New Status: ok
User "Catrope" also posted a comment on MediaWiki.r92923. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92923#c20607 Commit summary: Followup r86622: add initial QUnit test cases for jquery.textSelection module. * tests .textSelection()'s encapsulateText method mostly (also uses setSelection, getContents, and getSelection) * examples from WikiEditor toolbar: sig, bold, h2 (ownline), ulist (ownline & splitlines) * confirms that splitlines works more or less as expected, at least for basic single-line, single split-line, and multi-line cases Doesn't test the WikiEditor iframe mode since that's in a separate extension; when it's possible to test those things too, that'll need to be run there. One of the h2 tests fails in IE6, returning selected text that's offset by one character from what's expected. I'm not sure whether it's actually selecting the wrong text or whether it's returning the wrong text -- needs further investigation. Also note that there's no setContents submethod in textSelection, despite there being some notes about one. Comment: <pre> + * @param options {object} associative array containing: + * description {string} + * input {string} + * output {string} + * start {int} starting char for selection + * end {int} ending char for selection + * params {object} add'l parameters for $().textSelection('encapsulateText') </pre> This bit of documentation is almost completely wrong, probably outdated. OK otherwise. All the broken tests have been fixed in the meantime. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
