User "Krinkle" changed the status of MediaWiki.r91518. Old Status: ok New Status: fixme
User "Krinkle" also posted a comment on MediaWiki.r91518. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91518#c20629 Commit summary: (bug 6100; follow-up to r91315) Being bold and removing $wgBetterDirectionality (and dependent wfUILang) in core, as most or all work is finished. Also: * Introduce classes mw-float-end, mw-float-start so we don't have to use inline css depending on wfUILang()/$wgLang (see HistoryPage and SpecialFileDuplicateSearch) * Add direction mark to protection log * Remove specialpageattributes as it is obsoleted by this commit (also fixes bug 28572) * Add two direction marks in wfSpecialList, which makes ltr links on rtl wiki (and vice versa) display nicely as well (only on those special pages however) * Revert r91340 partially: use mw-content-ltr/rtl class anyway in shared.css. Both ways have their [dis]advantages... * Set the direction of input fields by default to the content language direction (except buttons etc.) in shared.css Comment: Somewhere around this commit, not exactly sure it's this one, the message "This category currently contains no pages or media." (msg key "category-empty") is shown '''outside''' the bodyContent on non-existant category pages of empty categories. See http://translatewiki.net/wiki/Category:Xklada for example. The closing "{{tag|div|c}}" on line 181 is the problem [http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/CategoryPage.php?revision=91518&view=markup#l172 here] _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
