User "Reedy" changed the status of MediaWiki.r84501. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84501#c0 Commit summary: 'Fix' fatal in LiquidThreads from r84475. I say 'fixed' in the loosest possible sense because I have absolutely no idea why that rev should have triggered this error. Accessing-method-of-non-object errors seem to be an ongoing bug in LQT (bug 17553), so I suspect that this was an edgecase waiting to happen, and the changes in r84475 just shifted codeflow around in such a way as to make it happen. All I've done here is make the "$article->getTitle()->equals()" comparisons safely become false if $article is null. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
