User "Dantman" posted a comment on MediaWiki.r93654.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93654#c20654
Commit summary:
Follows-up r93515 CR: Whitespace
Comment:
Sure, though you'll want to include an <code>} else { dependencies =
[modulename]; }</code> or <code>} else { dependencies = []; }</code> (I'm not
sure which makes more sense in the context of the code, the former is
functionally equiv to the previous code, but if having that there means extra
calls are made for a module we already know will be ignored the latter makes
more sense.
Just saying to make sure that the dependencies variable always ends up as an
array as the current code does.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
