User "Krinkle" posted a comment on MediaWiki.r94331. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94331#c20660 Commit summary:
Use jQuery's $.isArray, not instanceof Array. The later has troubles with cross-frame Array instances, and doesn't use the ES5 native method. Comment: Aside from the whitespace (which you already mentioned on IRC), $ is not available as a global here as jquery.mwExtension doesn't have a closure yet to call $ for jQuery. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
