User "Krinkle" posted a comment on MediaWiki.r94332.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94332#c20665
Commit summary:
Fix usage of the jQuery global in a few spots.
- jQuery changed to $ in some files because there is a closure that creates a
locally scoped $, but the jQuery var is globally scoped, meaning using jQuery
instead of $ inside that closure could result in interacting with a different
instance of jQuery than the uses of $ in that same closure.
- In mwExtension wrap the code inside a closure which it is missing. Also take
this chance to fix the whitespace style `fn( arg )` instead of `fn(arg)` on the
isArray I added.
This is partially a followup to r94331.
Note: The jquery plugins inside the jquery/ folder look fine for use of jQuery
within closures, except for mockjax.
Comment:
Indention in jquery.mwExtension.js is bit nasty in review but viewvc has the
whitespace flag on by default
http:/<nowiki>/svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/jquery/jquery.mwExtension.js?&pathrev=94332&r</nowiki><nowiki>1=94331&r</nowiki>2<nowiki>=94332</nowiki>
(<sup>yeah, that took a bunch of {{tag|nowiki|o}}'s to not make CodeReview
choke on it</sup>.
Looks good, marking ok.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
