User "Bryan" changed the status of MediaWiki.r94212.

Old Status: new
New Status: fixme

User "Bryan" also posted a comment on MediaWiki.r94212.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94212#c20673
Commit summary:

(bug 30192) Old thumbnails not properly purged. Unlike the bug suggests, we 
don't need to also purge from LocalFile::purgeCache(), since that code path 
ends up calling purgeHistory() anyway.

A lot of this could probably be protected...not much calls these outside of 
FileRepo code other than File::purgeCache()

Comment:

purgeHistory() is not actually called by File::purgeEverything().

Also the function description of LocalFile::purgeMetadataCache() is not valid 
anymore.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to