User "Jack Phoenix" posted a comment on MediaWiki.r94303.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94303#c20678
Commit summary:

fix for Bug 29520 - Ability to turn off images on mobile and wap-mobile page 
views

Comment:

<pre>
-                       $regularSite = 
self::$messages['mobile-frontend-regular-site'];
-                       $permStopRedirect = 
self::$messages['mobile-frontend-perm-stop-redirect'];
-                       $copyright = 
self::$messages['mobile-frontend-copyright'];
-                       $homeButton = 
self::$messages['mobile-frontend-home-button'];
-                       $randomButton = 
self::$messages['mobile-frontend-random-button'];
-                       $areYouSure = 
self::$messages['mobile-frontend-are-you-sure'];
-                       $explainDisable = 
self::$messages['mobile-frontend-explain-disable'];
-                       $disableButton = 
self::$messages['mobile-frontend-disable-button'];
-                       $backButton = 
self::$messages['mobile-frontend-back-button'];
+                       $regularSite            = 
self::$messages['mobile-frontend-regular-site'];
+                       $permStopRedirect       = 
self::$messages['mobile-frontend-perm-stop-redirect'];
+                       $copyright                      = 
self::$messages['mobile-frontend-copyright'];
+                       $homeButton                     = 
self::$messages['mobile-frontend-home-button'];
+                       $randomButton           = 
self::$messages['mobile-frontend-random-button'];
+                       $areYouSure                     = 
self::$messages['mobile-frontend-are-you-sure'];
+                       $explainDisable         = 
self::$messages['mobile-frontend-explain-disable'];
+                       $disableButton          = 
self::$messages['mobile-frontend-disable-button'];
+                       $backButton                     = 
self::$messages['mobile-frontend-back-button'];
+                       $disableImages          = 
self::$messages['mobile-frontend-disable-images'];
</pre>
[[Manual:Coding conventions#Vertical alignment]] recommends doing vertical 
alignment with spaces instead of tabs, but I think that more important is the 
recommendation that is stated on that manual page, too: '''Avoid vertical 
alignment'''.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to