User "Krinkle" changed the status of MediaWiki.r94370.

Old Status: new
New Status: fixme

User "Krinkle" also posted a comment on MediaWiki.r94370.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94370#c20687
Commit summary:

* Added LoggedUpdateMaintenance subclass
* Moved PopulateRevisionLength/PopulateRevisionSha1 scripts to 
$postDatabaseUpdateMaintenance
* Fixed bogus "{$prefix}_sha1 != ''" comparison (r94362)
* Removed unneeded NOT NULL check (speeds up script a bit) from 
populateRevisionSha1 script
* Various code cleanups

Comment:

Thanks, finally I can update my wiki again :-)
<pre>
Populating ar_sha1 column
...revision table seems to be empty.
rev_sha1 and ar_sha1 population complete [28 revision rows, 1 archive rows].
</pre>

The comment seems wrong though, it hardcodes "revision".

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to