User "Hashar" posted a comment on MediaWiki.r90849.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90849#c20696
Commit summary:
Apply rgcjones' patch for Bug#29533:
Whe placing an external link in the sidebar, $wgExternalLinkTarget is
ignored.
Also enables applying of $wgNoFollowLinks in the sidebar.
Comment:
That patch introduces code duplication :(
The part that check for $wgNoFollowLinks is copy/pasted from
Parser::getExternalLinkAttribs(). Although altered to not look at the Title
namespace, probably because we do not have a valid Title object in the context
of the sidebar.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
