User "Hashar" changed the status of MediaWiki.r94358.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94358#c0
Commit summary:

Renaming qunit test files to end in ".test.js" (finally!)

* There shouldn't be two files with the same name in core, especially not the 
module and the test suite. Previously postponed due to compatibility with our 
TestSwarm script, that has been fixed now.

* Had to modify the files in the same commit since the module name is 
referenced inside the test suite in the module() call, which is the hint for 
QUnit when filtering is done through the ?filter= parameter.

* As has been added to the conventions, there must be only one module() call 
per test suite file and it MUST match "filename without .test.js". Otherwise 
the module will not be submitted to TestSwarm (which glob()'s at the /suites/ 
directory and extracts test-suite-module-names from the filenames).

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to