User "Catrope" changed the status of MediaWiki.r94418. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r94418. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94418#c20723 Commit summary: * (bug 28893) Proofread Page extension needs an API module to retrieve page status Patch by John Du Hart Comment: <pre> + $pageQuality = $qualityLevels[ $data['categories'][0]['title'] ]; + if ( $pageQuality === null ) { </pre> This is not the right way to check for nonexistent keys, it'll throw notices. Use <code>isset( $qualityLevels[ ... ] )</code> instead. <pre> + 'api.php?action=query&generator=allpages&gapnamespace=104&prop=proofread' </pre> Copypaste leftover? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
