User "Catrope" changed the status of MediaWiki.r94434. Old Status: new New Status: ok
User "Catrope" also posted a comment on MediaWiki.r94434. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94434#c20724 Commit summary: * Better support for sister projects (wikiversity / wikisource): direct users to the respective sites * Set the title on info pages to a descriptive "Wikiproject Language" instead of "Wx/xyz" * Properly make the URLs of the logos Comment: <pre> + ) . ( $title ? preg_replace( '/\$1/', $title, $wgArticlePath ) : '' ); </pre> You can use <code>str_replace( '$1', $title, $wgArticlePath )</code> here too, you don't need a regex. <pre> + wfMsgExt( 'wminc-infopage-option-' . ( $this->mIsSister ? 'startsister' : 'startwiki' ), </pre> When you do stuff like this (dynamic message keys), please add a comment listing the literal message keys (wminc-infopage-option-startsister and wminc-infopage-option-startwiki in this case) so those keys can still be grepped easily. OK otherwise, marking OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
