User "Simetrical" changed the status of MediaWiki.r94385. Old Status: new New Status: fixme
User "Simetrical" also posted a comment on MediaWiki.r94385. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94385#c20749 Commit summary: Html5 player should be able to output actual valid Html5. Comment: - $s.= Xml::tags($tagName, $attr, ''); + $s.= Html::rawElement($tagName, $attr, ''); There's no reason to use Html::rawElement() if the contents are empty. There's no reason to provide the third parameter either, since it defaults to the empty string. This should be + $s.= Html::element( $tagName, $attr ); (note also spacing, while I'm at it). I dunno what the conventions are these days for marking fixme, so change this back to new if the fixme is unwarranted. I'll sign off as inspected with this change made. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
