User "SPQRobin" posted a comment on MediaWiki.r91340.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91340#c20779
Commit summary:

* Put float:left/right for images in shared.css with @noflip. This was 
inconsistent between skins, causing image alignment on RTL wikis to be 
dependent on your skin. Left is left and right is right, even for RTL languages 
:)
* Also moving position: relative; from all skins to shared.css
* Replacing .mw-content-ltr/rtl (added in r90743) with div#content 
[dir="ltr/rtl"] so it also works on e.g. special pages

Comment:

The change from <code>.mw-content-ltr/rtl</code> to <code>div#content 
[dir="ltr/rtl"]</code> is reverted meanwhile, so it is no longer relevant.
I don't think there are use cases where editsection is outside of 
<code>.mw-content-ltr/rtl</code> (it shouldn't, as the CSS needs that class for 
proper BiDi support of editsection).

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to