User "Tim Starling" posted a comment on MediaWiki.r94404. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94404#c20806 Commit summary:
Hopefully prevent race conditions in ArticleFeedback by reading from the master rather than the slave and using LOCK IN SHARE MODE. These race conditions probably caused bug 30227. Hopefully this will prevent that from happening again. Comment: Years ago, I tested LOCK IN SHARE MODE on InnoDB and found that it generates a deadlock pretty much every time there are two threads doing the same thing at the same time. I was unable to find a use for it apart from error generation. Maybe it's better in MySQL 5.1, but I wouldn't count on it. I think it's better to design your schema in a way that avoids locking reads, that's what I said in docs/database.txt. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
