User "Raindrift" changed the status of MediaWiki.r92009. Old Status: fixme New Status: new
User "Raindrift" also posted a comment on MediaWiki.r92009. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92009#c20825 Commit summary: Refactored UploadStash and related classes to use the database for file metadata storage instead of the session, see bug 26179 Tweaked the UploadWizard to work properly with the new backend code, updated tests Comment: re: || operator, I have no idea where I got the notion that such a thing would work. Looking at it myself, I'm like, "WTF?" Fixed. I'm not entirely sure why this didn't cause serious problems either, but I've added some tests to cover this code since we needed them anyway. regarding usage of empty(): I was just duplicating the behavior that was there before (Reedy's, I believe--all I changed is the name of the variable). However, I think you're right, and I've changed it to !. re: listfiles(), it should be checking against the user. Fixed. Regarding lag, I based my decision on the following statement in [http://www.mediawiki.org/wiki/Manual:Coding_conventions#PHP_pitfalls Database Access/Working with lag]: "To avoid swamping the master every time the slaves lag, use of this approach should be kept to a minimum. In most cases you should just read from the slave and let the user deal with the delay." UploadWizard could generate a page that requires a select for each of many images. I'm concerned about the load that could place on the master. I'll totally change it if you think it's best, but are you sure? Anyway, this is all implemented in r94536 except the lag stuff. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
