User "Hashar" posted a comment on MediaWiki.r94577. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94577#c20867 Commit summary:
back off r94558: - reverts ./includes/ProxyTools.php - marks tests broken In our test suite, the first call to wfGetIP() set the static variable. Hence the remaining of the code is only tested on the first call to it. Resetting the static variable enlight a bug somewhere in our code where we are calling wfGetIP() but can not reliably get an IP, somehow REMOTE_ADDR does not exist and $wgCommandLineMode is disabled. Will have to track this bug further when I got time. Comment: safer to back off this change to includes/ProxyTools.php :-) Next time I will run the full test suite before committing. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
