On Tue, Aug 16, 2011 at 7:15 AM, MZMcBride <[email protected]> wrote:
> Rather than something sane and predictable for the URL parameter to view > the > standard (non-mobile) site (such as &useFormat=standard), the code uses > ?mAction=view_normal_site. > > As I commented in CodeReview today, a boolean parameter (?disableImages=1) > has now been complemented with a completely separate parameter > (?enableImages=1) rather than using ?disableImages=0, which I find to be > very strange. > Also, a stylistic nitpick: MediaWiki usually doesn't camelCase for URL parameters, so &useFormat=... should ideally be changed to useformat for consistency. Probably, this could also achieved with $wgActionPaths-style rewrite rules, e.g. en.wikipedia.org/mobile/Artticle_Name ? -- Best regards, Max Semenik ([[User:MaxSem]]) _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
