User "Catrope" changed the status of MediaWiki.r94536. Old Status: new New Status: resolved
User "Catrope" also posted a comment on MediaWiki.r94536. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94536#c20898 Commit summary: Fixed incorrect usage of || operator, added test removed spurious use of empty() listFiles() was broken, now works followup to r92009 Comment: <pre> + return preg_match( UploadStash::KEY_FORMAT_REGEX, $key ) ? true : false; </pre> Instead of <code>? true : false</code> a cast to boolean is preferred: <code>return (bool)preg_match( ....</code> . _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
