User "Catrope" changed the status of MediaWiki.r94594. Old Status: new New Status: ok
User "Catrope" also posted a comment on MediaWiki.r94594. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94594#c20903 Commit summary: Removed the ability to pass a key into stashFile(), which simplifies the stash row creation a great deal. Updated UploadFromUrlJob to properly use the database stash followup to r92200 Comment: <pre> * @param $key String: (optional) the file key used to find the file info again. If not supplied, a key will be autogenerated. * @return UploadStashFile stashed file */ - public function stashFile( $key = null ) { + public function stashFile() { </pre> In this and pretty much every other instance, by the looks of it, you've removed the parameter from the function prototype but not from the doc comment. <pre> // if a row exists but previous checks on it passed, let the current user take over this key. </pre> This comment doesn't make sense anymore and should be removed. Why is the session still being used in UploadFromUrlJob? OK otherwise, marking as such, tagging todo for the comment issues. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
