User "Catrope" posted a comment on MediaWiki.r94566.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94566#c20905
Commit summary:

fix for fatal error caused by call to isMainPage

Comment:

<code>Title::isMainPage()</code> is not available in 1.17wmf1, which caused a 
fatal error when we deployed the code to testwiki.

Yes, this is inefficient and wrong (false positive if both the main page and 
<code>self::$title</code> don't exist). What you want is 
<code>Title::newMainPage()->equals( self::$title )</code>

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to