User "Catrope" changed the status of MediaWiki.r89853. Old Status: new New Status: resolved
User "Catrope" also posted a comment on MediaWiki.r89853. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89853#c20907 Commit summary: Added jquery.qunit.completenessTest.js (A jQuery/QUnit test coverage utility) * Added to /resources * Conditionally loaded (condition being that the url parameter "completenesstest" has a truthy value) * Fixed a test that was using === and true * Setting an added method somewhere back to undefined so it won't be listed as a potential "missing test". Comment: <pre> + console.log( 'CompletenessTest.ACTION_CHECK', that ); </pre> So this code assumes <code>console.log()</code> will be callable? Doesn't that cause JS errors on browsers where it's not present? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
