User "Hashar" changed the status of MediaWiki.r94577. Old Status: ok New Status: reverted
User "Hashar" also posted a comment on MediaWiki.r94577. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94577#c20910 Commit summary: back off r94558: - reverts ./includes/ProxyTools.php - marks tests broken In our test suite, the first call to wfGetIP() set the static variable. Hence the remaining of the code is only tested on the first call to it. Resetting the static variable enlight a bug somewhere in our code where we are calling wfGetIP() but can not reliably get an IP, somehow REMOTE_ADDR does not exist and $wgCommandLineMode is disabled. Will have to track this bug further when I got time. Comment: r94558 reintroduced with r94638 which is a reversion of this r94577. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
