User "^demon" posted a comment on MediaWiki.r94343.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94343#c20912
Commit summary:
Add a new type of ballot: Radio range with comment. Solicits the user for
comments, and sticks it in the ballot. This means that the size of ballots
changes, but not on the basis of the vote they take, which is the important
reason why ballot size cannot differ by the user (to avoid revealing the actual
votes).
Comment:
"for ( $offset = 0; $offset < strlen( $record ); $offset += $itemLength ) {"
Move the strlen() call above the loop?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
