User "SPQRobin" changed the status of MediaWiki.r94482. Old Status: fixme New Status: new
User "SPQRobin" also posted a comment on MediaWiki.r94482. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94482#c20942 Commit summary: Follow-up r92559: * Use preg_quote() for arrays going to regexes * Proper escaping for InfoPage->mFormatTitle and status message * Use wgOut->addModuleStyles() to prevent flash of unstyled content * Use $wgExtensionAssetsPath to form extension directory * Remove unneeded isset()s * Also, prevent php notices in onShowMissingArticle() Comment: preg_quote() done in r94674. I duplicated the code so it doesn't give php notices if 'lang' and 'realtitle' aren't defined (using isset() wouldn't give much shorter code). The onShowMissingArticle function should need a bit of cleanup/restructure anyway. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
