User "Tbleher" changed the status of MediaWiki.r94640. Old Status: ok New Status: fixme
User "Tbleher" also posted a comment on MediaWiki.r94640. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94640#c20949 Commit summary: Removed usage of internal API call in Special:AddComment that was broken by r83080; using WikiPage::doEdit() (or Article::doEdit() in earlier MW versions) instead. Comment: I think this commit is wrong, unfortunately. $article->doEdit() is an internal function and doesn't for example check if the user doing the edit is blocked. I ran into this while implementing this extension (it originally used doEdit()). The intention here is that the comment box should work exactly the same as the normal edit form from a user rights POV (ie all edit restrictions on namespaces, blocks, spam filters and so on should work there). After looking at all the edit code, I concluded that the only way to do this was to issue a fake request to the API. (I got this idea from another extension which was doing basically the same). I can't check right now using current SVN, but looking through trunk it seems like the code still works that way and so doEdit() can't be used here. I'd love to be proven wrong of course :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
