User "Bawolff" posted a comment on MediaWiki.r92141. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92141#c21033 Commit summary:
Babel: (bug 29663) Babel doesn't validate babel-autocreate-user message -> do nothing if the username is invalid. Also, do not create categories if the user is blocked. NewUserMessage: Fix fatal error when username is invalid. Instead, do nothing. Comment: I thnk this is using the wrong level of username validation. - Since category creation is a batch process, you should probably be doing valid <code>User::newFromName( wfMsgForContent( 'babel-autocreate-user' ), 'valid' )</code> . See the docs for <code>User::GetCanonicalName</code>. Not an issue with this commit, but since its touching this area of code I thought I'd mention, I don't think calling $article->doEdit while in the middle of parsing something is ok (I think it calls the parser recursively, which causes weird stuff to happen, like UNIQ everywhere) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
