User "^demon" posted a comment on MediaWiki.r94791. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94791#c21055 Commit summary:
r94720 Removes the backticks for the new database updater. Comment: I know this isn't the fault of this rev, but this is a perfect time to fix it (and it's the first time I've seen it): + PRIMARY KEY (id), + UNIQUE KEY contribution_id (contribution_id), + KEY ts (ts) We define our secondary keys outside of the CREATE TABLE statement, doing something like: CREATE INDEX /*i*/cr_repo_status_author ON /*_*/code_rev (cr_repo_id, cr_status, cr_author); Also, get rid of the PRIMARY KEY(id) and just add PRIMARY KEY to contribution_tracking.id's definition. These changes are good practice and make it compatible with Sqlite. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
