User "Patrick Nagel" posted a comment on MediaWiki.r94727. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94727#c21056 Commit summary:
Added support for specifying multiple (up to 10) addresses Comment: I thought about using trim(), but I'm not sure how the mailer function, that will get the untrimmed string as it came in from the user, will cope with \t, \n, \r, \0 or \x0B. I only know for sure that it can handle spaces. That's why I just remove the spaces for validation, and if there are any of the above listed characters still left, the validation function will just fail, and the list of e-mail addresses will not be used. In short - if I use trim() here, I need to go through string -> array -> trim(strings in array) -> string again somewhere else, and I prefer to keep it simple for now. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
