User "Catrope" posted a comment on MediaWiki.r94881.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94881#c21067
Commit summary:

Relative values of the "Location" header are incorrect as stated in RFC, 
however they do happen and modern browsers support them.
This function loops backwards through all locations in order to build the 
proper absolute URI - Marooned at wikia-inc.com

Comment:

This code uses parse_url(), which is subtly broken in a few ways and throws PHP 
warnings for invalid input. You might be better off using wfParseUrl() instead, 
see its documentation in GlobalFunctions.php

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to