User "Jlemley" posted a comment on MediaWiki.r94864.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94864#c21106
Commit summary:

Added personal URL option.

Comment:

Sorry, I'm not sure which global variables you're referring to.  If you mean 
$wgUseIconFavorite and $wgFavoritesPersonalURL, these are parameters that can 
be set in localsettings.php.  I suppose I could add:

if (!isset($wgUseIconFavorite)) $wgUseIconFavorite=false;
if (!isset($wgFavoritesPersonalURL)) $wgFavoritesPersonalURL=false;

Would that work better?

As for checking it inside the hook, I don't want to use the hook at all if the 
user doesn't want to use these features.  Does that make sense, or am I 
thinking about it wrong?


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to