User "Awjrichards" changed the status of MediaWiki.r94856. Old Status: new New Status: fixme
User "Awjrichards" also posted a comment on MediaWiki.r94856. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94856#c21135 Commit summary: date range for campaign log filter Comment: Stylistic point - can things like: <pre> + $startYear = $wgRequest->getVal( 'start_year' ); + if ( $startYear === 'other' ) $startYear = null; + $startMonth = $wgRequest->getVal( 'start_month' ); + if ( $startMonth === 'other' ) $startMonth = null; + $startDay = $wgRequest->getVal( 'start_day' ); + if ( $startDay === 'other' ) $startDay = null; + $endYear = $wgRequest->getVal( 'end_year' ); + if ( $endYear === 'other' ) $endYear = null; + $endMonth = $wgRequest->getVal( 'end_month' ); + if ( $endMonth === 'other' ) $endMonth = null; + $endDay = $wgRequest->getVal( 'end_day' ); + if ( $endDay === 'other' ) $endDay = null; </pre> be functionalized as this is happening in multiple places? Otherwise looks ok to me. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
