User "Jeroen De Dauw" posted a comment on MediaWiki.r93608.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93608#c21141
Commit summary:

do not show custom license selection option when there are no licenses 
available different then the default one

Comment:

Normally you don't have this, as it doesn't make sense, but you _can_ configure 
a campaign this way. So code needed for dealing with accidentally misconducted 
stuff to not mess up the UW is needed somewhere, and I figured here was the 
easiest place to put it. You can argue it's not really required, but removing 
it (and losing the little extra robustness) seems counter productive to me.

Why triple comparators? I don't see any situation in which using only double 
will cause problems here.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to