User "Awjrichards" posted a comment on MediaWiki.r92922.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92922#c21147
Commit summary:
Finishing banner settings logging. (specifically, changed content flag is now
accurate, and changed landing pages are also displayed now)
Comment:
Stylistic point:
<pre>
function logBannerChange( $action, $bannerId, $beginSettings = array(),
- $endSettings = array(), $beginContent = null, $endContent =
null )
+ $endSettings = array(), $contentChanged = 0 )
</pre>
It looks like $contentChanged is a bool, the way it's being used. If that's
the case, I suggest changing it to 'true'/'false' for clarity.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
