User "Awjrichards" changed the status of MediaWiki.r94316. Old Status: new New Status: fixme
User "Awjrichards" also posted a comment on MediaWiki.r94316. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94316#c21148 Commit summary: adding filters to central notice campaign setting logs Comment: <pre> + public static function dateSelector( $prefix, $editable, $timestamp = null ) { + if ( $editable ) { + $years = range( 2010, 2016 ); </pre> Is this introducing a y2k-like problem? Like in 2017 CentralNotice will break and the world will end because of this? This seems like an arbitrary and strange range to me. Could selecting the upper (and lower?) bound of the range be done dynamically? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
