User "Awjrichards" changed the status of Wikimedia.r413.

Old Status: new
New Status: fixme

User "Awjrichards" also posted a comment on Wikimedia.r413.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/413#c21152
Commit summary:

A quick module I threw together this morning, that allows dev-types to 
uninstall and re-install modules directly, without having to go through the 
many-click process of disabling things that depend on it before you can disable 
that module, uninstall, and re-install in order to test a schema change.
It should be noted that the module needs to be installed and enabled, before it 
will show up in the drop-down.

Comment:

I believe
<pre>
+    'access arguments' => array('Uninstalls and re-installs the selected 
module'),
</pre>
should be:
<pre>
'access arguments' => 'administer wmf test settings',
</pre>

This probably didn't break for you locally because your local user is likely 
the admin user (meaning they can do anything ever).  If a non-privileged user 
that had 'adminster wmf test settings' rights tried to use this as is, they 
would not be able to.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to