User "Awjrichards" changed the status of Wikimedia.r412. Old Status: new New Status: fixme
User "Awjrichards" also posted a comment on Wikimedia.r412. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/412#c21154 Commit summary: Adds the public_reporting module to drupal. At this point, the module will set up the public_reporting table on install. There is more work on the way for this module as defined in fundraiser card 208, points 212.1 and 212.2. Comment: <pre> +function public_reporting_perm() { + return array( 'Perform the Public Reporting schema changes.' ); +} </pre> These are better kept pithy - typically no more than a few words, all lowercase, not in a sentence. In fact, for the purposes of this module, this function is likely just not necessary - you don't appear to be checking permissions anywhere in the install file (which is typical), so you can likely just get rid of it unless you're planning to add other functionality to the module that will require permissions. Also, after using the db switcher to access the CiviCRM db, it's good practice to explicitly set it to use the default/drupal database after you're done. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
