User "Catrope" changed the status of MediaWiki.r92138. Old Status: new New Status: ok
User "Catrope" also posted a comment on MediaWiki.r92138. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92138#c21158 Commit summary: InputBox: * instead of checking each namespace if it is given through the parameter, check each given namespace if it is a valid one * this fixes the inconsistency where 2 namespaces are given but only 1 is valid and that one is shown (normally if there is only 1 given, it is hidden) * fix bug 22591 (Allow i18n of Main namespace search option label) * allow namespace aliases as well * also trim the given namespaces, so spaces do not make them invalid Comment: <pre> + if ( strstr( $userNS, '**' ) ) { </pre> >From the PHP manual: <blockquote> If you only want to determine if a particular needle occurs within haystack, use the faster and less memory intensive function strpos() instead. </blockquote> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
