User "Nikerabbit" posted a comment on MediaWiki.r95043.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95043#c21166
Commit summary:

line numbers and better style

* new system to parse the diff, see parseLine() dispatcher.
* show lines numbering for each chunk.
* tweak style to replace the <pre> look'n feel, removing the first-child
  last-child selectors.
* line numbers are not selected on mouse selection. Makes it easy to
  copy paste the patch.

Note: old code left unchanged. To use it again, change the array_map
callback in splitLines from 'parseLine' to 'colorLine'.

Comment:

<pre>
+       private $left  = 0;
+       private $right = 0;
+       private $chunk = 0;
</pre>

Why private?

<source lang=php>
+               $left = $right = '&nbsp;';
</source>

Use numerical entities or the symbol itself.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to