User "Catrope" changed the status of MediaWiki.r87546.

Old Status: new
New Status: fixme

User "Catrope" also posted a comment on MediaWiki.r87546.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87546#c21182
Commit summary:

Update RSS to add the ability to restrict per-namespace.

Comment:

<pre>
+               if ( $wgRSSNamespaces !== null && is_array($wgRSSNamespaces) ) {
</pre>
This is redundant, <code>is_array(null)</code> is false.

Did any follow-up come out of that IRC discussion? Provisionally marking fixme 
for the array_flip() weirdness and Chad's claim that it "isn't working".

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to