User "NeilK" posted a comment on MediaWiki.r94726.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94726#c21120
Commit summary:
*Changes to spider.php to use wfShellExec instead of shell_exec
*Updates to log parsing regexes, including using lazy instead of greedy where
applicable
*Fix results array to be in correct format
Comment:
@$wgArchiveLinksConfig['filestore']
For your switches you are using the 'shutup' operator a lot. We don't use the
"shutup" operator unless it's absolutely necessary. Just wrap it in another if
statement.
Please don't commit debug code like the //echo "\n\nwget.exe and the next
foreach after that
@$fp = fopen( $log_path, 'r' ) or die( 'can\'t find wget log file to
parse' );
This is confusing, what is the @ symbol even for if you die?
Otherwise looks okay
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
