User "Khorn (WMF)" posted a comment on MediaWiki.r94720. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94720#c21139 Commit summary:
In the process of adding an API to ContributionTracking, I ended up refactoring the majority of the extension. Many changes and additions, including the new API, a jquery module that uses the API, and an unlisted sysop-only API testing page. Comment: In reverse order: I took out the $key argument in ContributionTracking_body because the class's grandparent (SpecialPage) already has a msg() function defined with no args. Leaving it with the $key arg as it was in ContributionTracking_body causes strict error reporting to go nuts, to the point it occasionally doesn't report more serious errors at all. The other classes in the extension do not have that particular inheritance problem. However: Yes, it's totally inconsistent. :) I will change the var name in the first point momentarily. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
