User "Bawolff" posted a comment on MediaWiki.r86534.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86534#c21234
Commit summary:
(bug 23816) Add tracking category for any page with a broken image.
Note this considers a link to a non-existent image to be broken. A link
to an image that exists but does not have a handler is not considered broken.
Comment:
So it would seem to make sense to disable all categories on special pages (aka
things that use $wgOut->addWikiText and friends which as far as I can tell is
only special pages).
Proposed fix (this is to the function <tt>OutputPage::addWikiTextTitle</tt>):
<source lang="diff">
Index: includes/OutputPage.php
===================================================================
--- includes/OutputPage.php (revision 95155)
+++ includes/OutputPage.php (working copy)
@@ -1375,6 +1375,9 @@
$popts->setTidy( $oldTidy );
+ # Don't want categories in message pages to affect
+ # special pages and the like.
+ $parserOutput->setCategoryLinks( array() );
$this->addParserOutput( $parserOutput );
wfProfileOut( __METHOD__ );
</source>
I'm not 100% sure if that's sane, but seems the best solution to me. Thoughts?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
