User "Bawolff" changed the status of MediaWiki.r86169. Old Status: fixme New Status: new
User "Bawolff" also posted a comment on MediaWiki.r86169. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86169#c21238 Commit summary: Merge to trunk everything in img_metadata branch. Hope I did this in an ok fashion. svn merge --re-integrate was giving me issues so I just essentially over-wrote my working copy with the version at img_metadata. Comment: As of r95163 this is pretty well covered by unit tests, so I'm going to reset to new and rm the need unit tests keyword. >I do see at least one thing claiming 'version 2' metadata though -- what's the >output look like? The metadata converty thing is mostly to make older versions of instant commons happy with the new type of metadata that jpeg's output. With this revision jpeg's can have metadata properties that are multi-valued - for example you can have a file with multiple authors. Older MediaWiki will throw a fit if any of the jpeg metadata keys have non-string values, so the convert function converts everything back to a string. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
