User "Nikerabbit" posted a comment on MediaWiki.r95185.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95185#c21253
Commit summary:
Added resources for AJAX-ifying the signup form
Made AJAX & source tracking user configurable
Added extension specific messages to i18n file
Comment:
Mediawiki doesn't use Title Case:
+'signupapi-passwordsmatch' => 'Passwords Match',
There is no way to turn this of. It should be in a hook or extension function.
+if ( $wgSignupAPIUseAjax ) {
Where does 'ok' and 'badretype' come from?
+ 'messages' => array( 'ok', 'signupapi-enterpassword',
'passwordtooshort', 'signupapi-weak', 'signupapi-medium', 'signupapi-strong',
'badretype', 'signupapi-passwordsmatch' ),
Style guide advocates that braces don't take their own line
+ function addSourceTracking( &$personal_urls, &$title )
+ {
+ }
+ else {
The special page is named UserSignup (2x)
+ $title = SpecialPage::getTitleFor( 'Usersignup' );
Class names usually start with a capital letter:
+class validateSignup extends ApiBase {
Why did you name it mUser? m prefix usually refers to object member variables.
+ $mUser = User::newFromName( $params['inputVal'],
'creatable' );
Please use tabs for indentation.
Don't you need to escape these values?
+ data:
"action=validatesignup&format=json&field="+fieldtype+"&inputVal="+inputVal,
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
