User "NeilK" changed the status of MediaWiki.r93528. Old Status: new New Status: ok
User "NeilK" also posted a comment on MediaWiki.r93528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93528#c21288 Commit summary: Added TitleBlacklist::singleton() to get an instance of the TitleBlacklist instead of having to use $wgTitleBlacklist and call efInitTitleBlacklist() Comment: Looks good to me. I don't see anything else in our codebase that cares about $wgTitleBlacklist, so this should be a clean replacement -- with the exception of the Configure extension, and in that case it's just making an exception for that variable. But you might want to update Configure as well. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
