User "Mdale" posted a comment on MediaWiki.r84395. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84395#c21294 Commit summary:
(bug 27641) purgeThumbnails should support exclusion of expensive files. Add $wgExcludeFromThumbnailPurge and don't purge thumbnails whose extension is in that array when the files they belong to are purged with action=purge. Committing patch by Michael Dale with small coding style tweaks Comment: I don't think that’s a good idea. This would mean adding another hook of some sort to build this list since each extension adds in support for new file extensions to be supported its impossible for every call to purgeThumbnails to know about every extension that adds new file types. I suggest that we have another function called removeThumbnailFolder or a parameter to "force remove everything" if you want to have the ability for purge calls to clear all the thumbnails associated with an asset. We want to keep some concept of default "light purge" that user invoked action=purge calls so that we are not constantly removing assets that are expensive to recreate. We can't have all the calls to purgeThumbnails know about all the file types that extensions add without some variable similar to what we already have in place . _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
